-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Plasma Graph to Allow .dot and .tex file Generation #1868
Conversation
…fully and to allow graphs to be displayed within a notebook; rewrote documentation to reflect this [build docs]
Codecov Report
@@ Coverage Diff @@
## master #1868 +/- ##
==========================================
+ Coverage 62.12% 62.34% +0.22%
==========================================
Files 66 68 +2
Lines 6809 7149 +340
==========================================
+ Hits 4230 4457 +227
- Misses 2579 2692 +113
Continue to review full report at Codecov.
|
That looks interesting. Just a quick reminder - one PR one idea. In this PR there is the idea of fixing the old version and adding a new way of plotting this. Let's make a PR that fixes the old version first. Then we make a new PR that has the |
…aphs better [build docs]
…d randomized scaling factor to edges to display graph in a more readable format
… for graph [build docs]
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ameter, reformatted into PEP8 style [build docs]
… docs to reflect changes [build docs]
The failed black test flagged multiple files which I did not edit nor are a part of this pull request |
Before a pull request is accepted, it must meet the following criteria:
|
…ers for displaying graphs with changable parameter [build docs]
Description
This reworks the code necessary to generate the .dot and .tex files for the plasma graph. The documentation regarding the graph has been changed to reflect this.
Motivation and context
The current way TARDIS builds the .dot file makes it raise errors upon attempting to build the .tex file, and the latex code within the .dot file, if written into a .tex file without using TARDIS, is displayed incorrectly.
How has this been tested?
Examples
https://bartnikm.github.io/tardis-bartnikm/branch/plasma-graph/physics/setup/plasma/index.html#the-plasma-graph
Below are two graphs of the same configuration file. The first one had no entries passed into the
args
parameter:Sample_Graph_no_args.pdf
The second one had the following passed:
[r"nodesep=1.0", r'edge[lblstyle="fill=white"]', r'margin=0', r'ratio="fill"', r'size="8.3,11.7!"']
Sample_Graph_with_args.pdf
Type of change
Checklist