-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing small docs issues #1893
Fixing small docs issues #1893
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1893 +/- ##
=======================================
Coverage 62.55% 62.55%
=======================================
Files 68 68
Lines 7127 7127
=======================================
Hits 4458 4458
Misses 2669 2669
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the black error in arepo.py
Description
This PR:
export
method. This is needed for the documentation as currently rerunning the documentation build will add two extra untracked files every run. This way we will only have two files generated that are added to.gitignore
. This is also important for users in general if users want to make changes and re-export the snapshot without cluttering their downloads.How has this been tested?
Docs built on GitHub.
Examples
Docs build logs with no warnings: https://github.com/smithis7/tardis/runs/5117973003
Main edited docs page: https://smithis7.github.io/tardis/branch/arepo_warning_fix_doc/io/configuration/components/models/converters/arepo_to_tardis.html
Type of change
Checklist