Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TARDIS bridge for Carsus collisions #1975

Closed

Conversation

laureanomartinez
Copy link
Contributor

@laureanomartinez laureanomartinez commented Apr 25, 2022

Description

See also: tardis-sn/carsus#293

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@laureanomartinez laureanomartinez marked this pull request as draft April 25, 2022 15:20
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1975 (854d9b6) into master (66eb19f) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 854d9b6 differs from pull request most recent head 59526be. Consider uploading reports for the commit 59526be to get more accurate results

@@            Coverage Diff             @@
##           master    #1975      +/-   ##
==========================================
- Coverage   60.01%   60.00%   -0.01%     
==========================================
  Files          70       70              
  Lines        8115     8117       +2     
==========================================
+ Hits         4870     4871       +1     
- Misses       3245     3246       +1     
Impacted Files Coverage Δ
tardis/plasma/properties/atomic.py 54.87% <0.00%> (-0.23%) ⬇️
tardis/io/atom_data/base.py 89.77% <100.00%> (+0.05%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro epassaro force-pushed the continuum_collisions branch 2 times, most recently from e94bd28 to c89c54b Compare May 5, 2022 18:52
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@epassaro epassaro changed the title tardis bridge for collisions TARDIS bridge for Carsus collisions May 5, 2022
@Rodot-
Copy link
Contributor

Rodot- commented May 11, 2022

#2019 makes this PR no longer necessary, right?

@epassaro
Copy link
Member

Right. Closing.

@epassaro epassaro closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants