As simpler run_tardis
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
|
|
||
| try: | ||
| config_dict = yaml.load(open(config)) |
There was a problem hiding this comment.
@mklauser You were interested in duck-typing. This is a classic example. You could do a type check to see if is as string, but one simply opts to give it to the python open command and then sees if it works. This means also unicode strings can work, or other things that open can read.
|
@ssim while you are online - are you happy with this change (includes updated documentation) |
|
This looks sensible to me. Happy to sign off - go ahead and merge, @wkerzendorf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
run_tardisfunction has been a bit annoying (one needed to first open the yml file and then give it to run_tardis). This function update hopefully made it a lot simpler (@unoebauer see if this is to your liking)@mklauser @ssim @orbitfold one of you please sign off (or object) so we can merge this.