-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger docs only when something inside the docs folder changed #2587
Conversation
9b6e30b
to
9e86bba
Compare
Why are the tests failing in this PR? |
Can you please include example workflows- conditions when the workflow ran successfully? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Abhinav, I believe the workflow will now run if there are changes in the docs folder. But someone will still be able to run it manually too using the build-docs label(without skipping), as a test?
The regression cache was corrupt(size was in bytes). Deleted the cache and now it works. |
What should be its behavior when we manually run it? If there are no changes in the docs then it should not do anything or it should run all the steps? |
With |
e90203c
to
bbf51de
Compare
Printing exit code fixing if condition Changing exit code
7454a38
to
45ddf64
Compare
Yes, we can run it manually, by either manually running the workflow or by adding the build docs label to the PR. |
40ba4b1
to
cf4c5b7
Compare
456e485
to
66d74de
Compare
There is a merge conflict. Also, can you provide example workflow links? |
Here are the workflow links which i an on my personal forks: |
📝 Description
Type: 🎢
infrastructure
I am trying to implement a conditional logic in the docs workflow so that the docs trigger only if there is a change in any of the files in the docs directory.
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label