-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre Release Zenodo Not Found #2835
Pre Release Zenodo Not Found #2835
Conversation
*beep* *bop* 1 E999 SyntaxError: Expected an expression
Complete output(might be large): .github/workflows/pre-release.yml:7:4: E999 SyntaxError: Expected an expression
Found 1 error.
|
Why are we not getting a new zenodo.json made? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2835 +/- ##
==========================================
- Coverage 70.89% 70.51% -0.39%
==========================================
Files 209 209
Lines 15589 15589
==========================================
- Hits 11052 10992 -60
- Misses 4537 4597 +60 ☔ View full report in Codecov by Sentry. |
4a980be
to
09f4867
Compare
09f4867
to
44ea472
Compare
*beep* *bop* Significantly changed benchmarks: All benchmarks: Benchmarks that have stayed the same:
| Change | Before [3b6084f2] <master> | After [44ea4729] | Ratio | Benchmark (Parameter) |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
| | 481±200ns | 631±100ns | ~1.31 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation |
| | 45.6±20μs | 58.6±20μs | ~1.29 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission |
| | 21.8±5μs | 19.6±4μs | ~0.90 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
| | 3.31±0.02ms | 2.68±0.01ms | ~0.81 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter') |
| | 3.74±0.01ms | 4.09±0.01ms | 1.09 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom') |
| | 2.74±0.5μs | 2.94±0.3μs | 1.07 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket |
| | 2.03±0.8μs | 2.09±1μs | 1.03 | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators |
| | 631±200ns | 641±200ns | 1.02 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation |
| | 561±200ns | 571±100ns | 1.02 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation |
| | 37.3±0.1s | 37.5±0.06s | 1.01 | run_tardis.BenchmarkRunTardis.time_run_tardis |
| | 209±0.06ns | 211±0.1ns | 1.01 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body |
| | 1.20±0μs | 1.21±0μs | 1.01 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary |
| | 1.67±0ms | 1.68±0.01ms | 1.01 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop |
| | 1.03±0m | 1.03±0m | 1.00 | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking |
| | 2.08±0m | 2.08±0m | 1.00 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions |
| | 44.4±20μs | 43.8±30μs | 0.99 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter |
| | 3.67±0.1μs | 3.65±0.2μs | 0.99 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell |
| | 32.1±0.01μs | 31.1±0.03μs | 0.97 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list |
| | 6.21±0.8μs | 6.05±1μs | 0.97 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket |
| | 1.76±0.3μs | 1.69±0.3μs | 0.96 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line |
| | 65.3±0.1ms | 62.8±0.5ms | 0.96 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe |
| | 762±0.4ns | 711±0.2ns | 0.93 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter |
| | 2.76±0.6ms | 2.56±0.4ms | 0.93 | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop |
| | 7.36±2μs | 6.85±1μs | 0.93 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley |
If you want to see the graph of the results, you can check it here |
* Bypass zenodo not found * Use conditionals to check for zenodo file
* Bypass zenodo not found * Use conditionals to check for zenodo file
* Bypass zenodo not found * Use conditionals to check for zenodo file
* Bypass zenodo not found * Use conditionals to check for zenodo file
📝 Description
Type: 🪲
bugfix
| 🚀feature
| ☣️breaking change
| 🚦testing
| 📝documentation
| 🎢infrastructure
https://github.com/tardis-sn/tardis/actions/runs/11108638074/job/30862049889
Should result in the pull request opening even if zenodo file not generated. I think pre release should pick up the default .zenodo file available.
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label