Plasma/multiple outputs #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aoifeboyle that's great - let me know how NLTE goes. |
|
@wkerzendorf How's this? Travis is fine but the coverage test fails. I'll be adding more tests later. Should I merge? |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
electron_densityto theIonNumberDensityclass as a second output. Seems to work great! Thanks @wkerzendorf. I ran a quick simulation to compare the results to when the separateElectronDensityclass was used, and they were identical. Next step is to pick up where I left off with the NLTE stuff.