Simulation - restructure #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will be willing to do the testing.What unit tests do I need to write for this? |
Closed
|
@souravsingh I think this is work relatively deep inside the code. To get a good overview, you should do the colorize the logger part. |
|
@wkerzendorf There are no objections on my part. |
wkerzendorf
force-pushed
the
simulation/restructure
branch
2 times, most recently
from
730d2c8 to
a419517
Compare
wkerzendorf
force-pushed
the
simulation/restructure
branch
from
a419517 to
df96a6b
Compare
|
@tardis-sn/tardis-core merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have restructured the simulation part of TARDIS to be able to do runs that allow to get a consistent plasma state with just a given t_inner. In the process - the model and the simulation have been disentangled. @tardis-sn/tardis-core I'll need some testing and feedback,