Misleading header file

[theaverageguy]

Fixes #489

[wkerzendorf]

@chvogl @yeganer @mreinecke can you guys look at this? I can't remember if that was a sensible fix.

[yeganer]

@theaverageguy Thank you for the contribution.
@wkerzendorf The change is fine but there are two issues:

• The 1st commit won't compile since there will be two declarations of line_search
• After the 2nd commit there will be an import error because cmontecarlo1.h is deleted.

I suggest you remove the include "cmontecarlo1.h" from cmontecarlo.h and then combine all commits into one commit that covers the whole change with a litte explanation in the body of the commit message summarizing what and why it changed.

[mreineck]

Also, you need to remove the
#include "cmontecarlo1.h"
from rpacket.h and add
#include "cmontecarlo1.h"
to rpacket.c.

[mreineck]

Sorry, correction ....
of course you need to
#include "cmontecarlo.h"
from rpacket.c.

[yeganer]

@mreineck thanks, I totally forgot that rpacket.c is missing this #include.

In general there needs to be some cleanup of header files. Headers should only #include ... stuff the header needs. Everything else goes into the corresponding source file.

@wkerzendorf I'm not sure if it is a good idea to include these changes within this PR or if we want a new PR for header cleanup.

[yeganer]

#531 Fixed the corresponding issue. Closing this.