Save coverage report when tests use tardis-refdata #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously coverage report was saved, when tests run without tardis-refdata parameter. So, the tests which depend on tardis-refdata or atomic-dataset were not included in coverage. This commit aims to change that.
|
@wkerzendorf @yeganer Can you review this PR? |
|
Coverage increases by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently coverage report is saved, when tests run without
tardis-refdataparameter. So, the tests which depend ontardis-refdataoratomic-datasetwere skipped, and files which depend on these, are not included in coverage. This PR aims to change that, as many tests , such as tests for Plasma, depend on this parameter(tardis-refdata), and coverage report does not correctly reflect the status for same.