Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full test for formal integral method #850

Merged

Conversation

unoebauer
Copy link
Contributor

@unoebauer unoebauer commented Jul 27, 2018

This PR adds another test for the formal integral method, specifically checking the final spectrum determined with this scheme. The setup is very similar to the one used for test_tardis_full.py.

  • add new test with modified setup
  • test for integrated spectrum
  • test formal integral for both macroatom and downbranch modes
  • update reference data
  • update documentation

@unoebauer unoebauer force-pushed the add_full_formal_integral_test branch from a3ee17b to f266441 Compare August 2, 2018 11:32
@unoebauer unoebauer force-pushed the add_full_formal_integral_test branch from 5c33eed to 10af665 Compare August 3, 2018 14:49
@unoebauer
Copy link
Contributor Author

@wkerzendorf - please review (and merge once Travis is happy)

@unoebauer unoebauer requested review from wkerzendorf and chvogl August 8, 2018 10:45
Copy link
Member

@wkerzendorf wkerzendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice

@wkerzendorf wkerzendorf merged commit 22cdfbe into tardis-sn:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants