Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas ix fix #886

Merged
merged 9 commits into from
Feb 26, 2019
Merged

Pandas ix fix #886

merged 9 commits into from
Feb 26, 2019

Conversation

wkerzendorf
Copy link
Member

@wkerzendorf wkerzendorf commented Feb 25, 2019

fixing the pandas deprecated use of .ix
convert several python 2 to python 3 within the code.

@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

Merging #886 into master will not change coverage.
The diff coverage is 78.2%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #886   +/-   ##
=======================================
  Coverage   65.77%   65.77%           
=======================================
  Files          83       83           
  Lines        5922     5922           
=======================================
  Hits         3895     3895           
  Misses       2027     2027
Impacted Files Coverage Δ
tardis/util/base.py 77.58% <0%> (ø) ⬆️
tardis/io/tests/test_ascii_readers.py 100% <100%> (ø) ⬆️
tardis/io/tests/test_decay.py 100% <100%> (ø) ⬆️
tardis/model/base.py 89.61% <100%> (ø) ⬆️
tardis/plasma/properties/general.py 100% <100%> (ø) ⬆️
tardis/plasma/properties/partition_function.py 92.37% <100%> (ø) ⬆️
tardis/montecarlo/base.py 87.33% <100%> (ø) ⬆️
tardis/plasma/properties/level_population.py 100% <100%> (ø) ⬆️
tardis/io/model_reader.py 97.41% <100%> (ø) ⬆️
tardis/plasma/properties/atomic.py 94.62% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b4472...73348da. Read the comment docs.

@wkerzendorf
Copy link
Member Author

@chvogl @ssim if one of you could quickly sign off on this.
checks pass.

@wkerzendorf wkerzendorf merged commit e61beb6 into tardis-sn:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants