Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log additional properties in hdf witeout when --with-vpacket-logging is present #967

Merged

Conversation

kaushik94
Copy link
Contributor

@kaushik94 kaushik94 commented Sep 29, 2019

@wkerzendorf this is an attempt at fixing #800 . I am not sure how to proceed from here. Can you please tell which other classes you would like me to add these properties? Or does this satisfy?

…is enabled

* tardis/montecarlo/base.py: added a check to see if with_vpacket_logging in get_disutils_option and then extend hdf_properties with the required properties
@wkerzendorf
Copy link
Member

@kaushik94 - we'll have a look - thanks

…g' is enabled - working

1. /tardis/montecarlo/base.py - implemented logic to check if vpacket_logging is set to true in
   a file 'vpacket_config.yml'
2. /tardis/montecarlo/setup_package.py - function to set vpacket_logging to True when the flag
   is enabled at compile time
@wkerzendorf wkerzendorf merged commit f451b68 into tardis-sn:master Nov 20, 2019
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
…is present (tardis-sn#967)

* log additional properties in hdf witeout when --with-vpacket-logging is enabled

* tardis/montecarlo/base.py: added a check to see if with_vpacket_logging in get_disutils_option and then extend hdf_properties with the required properties

* added import for get_distutils_option

* Feature for logging additional properties when '--with-vpacket-logging' is enabled - working
1. /tardis/montecarlo/base.py - implemented logic to check if vpacket_logging is set to true in
   a file 'vpacket_config.yml'
2. /tardis/montecarlo/setup_package.py - function to set vpacket_logging to True when the flag
   is enabled at compile time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants