Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Output Enhancements #112

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Script Output Enhancements #112

merged 2 commits into from
Nov 16, 2023

Conversation

tareqimbasher
Copy link
Owner

@tareqimbasher tareqimbasher commented Nov 15, 2023

Introduces a number of optimizations and fixes to script output rendering that provide a better user experience and better protection against large number of outputs that cause app to hang:

  • Fixed ability to stop/cancel all scripts
  • Script output messages will be stopped when a script environment stops, effectively cancelling sending script output messages to IPC client when the user stops a script
  • Throttles pushing script output messages to IPC client, protecting against overflow and page hang
  • Limits max number of script output messages to push to IPC client in a single script run
  • Optimizations in rendering output within SPA
  • Better visual representation of errors and other types of script output

The change introduces:
- Throttles pushing script output messages to IPC client
- Limits max number of script output messages to push to IPC client in a single script run
- Script output messages will be cancelled when a script environment stops, effectively cancelling sending script output messages to IPC client
- Optimizations in rendering output within SPA. Rendering is now debounced and pre-rendering work is more optimized
@tareqimbasher tareqimbasher self-assigned this Nov 15, 2023
@tareqimbasher tareqimbasher linked an issue Nov 15, 2023 that may be closed by this pull request
@tareqimbasher tareqimbasher merged commit 3bf03d6 into main Nov 16, 2023
8 checks passed
@tareqimbasher tareqimbasher deleted the fix/stop-runaway-scripts branch November 16, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant