Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/users: fix secondary action rendering in safari #1624

Merged
merged 5 commits into from
Jun 17, 2021
Merged

Conversation

dctalbot
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR fixes a CSS issue in Safari when rendering wider secondary list actions. It solves the immediate problem of the content wrapping, but there is some outstanding work to be done preventing longer list item text from rendering behind the secondary action. See additional info below for more context. This is an existing bug today, so a separate PR will address it.

Which issue(s) this PR fixes:
Fixes #1500

Describe any introduced user-facing changes:
Safari users can manage contact methods

Additional Info:
mui/material-ui#13597
mui/material-ui#13495

@pnengchu pnengchu self-requested a review June 16, 2021 15:22
@dctalbot dctalbot merged commit d9a3489 into master Jun 17, 2021
@dctalbot dctalbot deleted the tsx-user-cm-list branch June 17, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui/users: contact method actions are not rendered correctly in safari
3 participants