Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of Eviction API to reap pods #68

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

bewing
Copy link
Contributor

@bewing bewing commented Jun 22, 2021

Add boolean option to use Eviction API, which will honor PodDisruptionBudgets when attempting to delete/remove/reschedule a pod

Copy link
Collaborator

@brianberzins brianberzins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested on eviction permission verb!
Otherwise looks good!

chart/pod-reaper/templates/rbac.yaml Outdated Show resolved Hide resolved
reaper/reaper.go Show resolved Hide resolved
Add boolean option to use Eviction API, which will honor
PodDisruptionBudgets when attempting to delete/remove/reschedule a pod
@brianberzins brianberzins merged commit 282775c into target:master Jun 24, 2021
@brianberzins
Copy link
Collaborator

Really appreciate the PR!
2.10.0 was automatically built and uploaded to dockerhub!

@bewing bewing deleted the evict branch June 28, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants