Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Adds in a mimetype check to verify that the given file is in fact an XML file when an error is thrown by the XML scanner in order to verify that the file in question is a XML file. This is done in the error handling section of the scanner instead of the start of the scanner in order to preserve the validity of the existing test cases.
Describe testing procedures
Tested with opensource Strelka in order to see results in the results in the StrelkaUI, which will be shown below. Specifically tested with .zip files in order to emulate cases in which this was seen in other worker instances
Sample output
With the above change, the ScanXML bucket still appears in the UI, though contains only the following flag:
Checklist