Skip to content

Commit

Permalink
src: enable vector ics on arm again
Browse files Browse the repository at this point in the history
The flag is no longer supported by V8 4.5, and the original issue [1] on ARMv6
no longer manifests with (at least) 4.5.103.20.

[1] See https://code.google.com/p/v8/issues/detail?id=4338

PR-URL: nodejs#2509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
ofrobots authored and targos committed Aug 28, 2015
1 parent 590aae7 commit 5d45ebf
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3611,11 +3611,6 @@ void Init(int* argc,
// TODO(bnoordhuis): Remove test/parallel/test-arm-math-exp-regress-1376.js
// and this workaround when v8:4019 has been fixed and the patch back-ported.
V8::SetFlagsFromString("--nofast_math", sizeof("--nofast_math") - 1);
// See https://github.com/nodejs/node/pull/2220#issuecomment-126200059
// and https://code.google.com/p/v8/issues/detail?id=4338
// TODO(targos): Remove this workaround when v8:4338 has been fixed and the
// patch back-ported.
V8::SetFlagsFromString("--novector_ics", sizeof("--novector_ics") - 1);
#endif

#if defined(NODE_V8_OPTIONS)
Expand Down

0 comments on commit 5d45ebf

Please sign in to comment.