lib: set abort-controller toStringTag

PR-URL: nodejs#36115 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos · Apr 30, 2021 · a2cf563 · a2cf563
1 parent 6b3a21c
commit a2cf563
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/lib/internal/abort_controller.js b/lib/internal/abort_controller.js
@@ -6,7 +6,9 @@
 const {
   Object,
   ObjectSetPrototypeOf,
+  ObjectDefineProperty,
   Symbol,
+  SymbolToStringTag,
   TypeError,
 } = primordials;
 
@@ -54,6 +56,13 @@ Object.defineProperties(AbortSignal.prototype, {
   aborted: { enumerable: true }
 });
 
+ObjectDefineProperty(AbortSignal.prototype, SymbolToStringTag, {
+  writable: false,
+  enumerable: false,
+  configurable: true,
+  value: 'AbortSignal',
+});
+
 defineEventHandler(AbortSignal.prototype, 'abort');
 
 function createAbortSignal() {
@@ -97,6 +106,13 @@ Object.defineProperties(AbortController.prototype, {
   abort: { enumerable: true }
 });
 
+ObjectDefineProperty(AbortController.prototype, SymbolToStringTag, {
+  writable: false,
+  enumerable: false,
+  configurable: true,
+  value: 'AbortController',
+});
+
 module.exports = {
   AbortController,
   AbortSignal,

diff --git a/test/parallel/test-abortcontroller.js b/test/parallel/test-abortcontroller.js
@@ -61,3 +61,10 @@ const { Event } = require('internal/event_target');
     /^TypeError: Illegal constructor$/
   );
 }
+{
+  // Symbol.toStringTag
+  const toString = (o) => Object.prototype.toString.call(o);
+  const ac = new AbortController();
+  strictEqual(toString(ac), '[object AbortController]');
+  strictEqual(toString(ac.signal), '[object AbortSignal]');
+}
diff --git a/test/parallel/test-eventtarget-memoryleakwarning.js b/test/parallel/test-eventtarget-memoryleakwarning.js
@@ -23,7 +23,7 @@ common.expectWarning({
      'Use events.setMaxListeners() to increase ' +
      'limit'],
     ['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
-     '[AbortSignal [EventTarget]]. ' +
+     '[AbortSignal]. ' +
      'Use events.setMaxListeners() to increase ' +
      'limit'],
   ],