Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arithmetic lint does not play nicely with stable #119

Closed
AaronFeickert opened this issue Mar 5, 2024 · 1 comment
Closed

Arithmetic lint does not play nicely with stable #119

AaronFeickert opened this issue Mar 5, 2024 · 1 comment

Comments

@AaronFeickert
Copy link
Contributor

The linting CI is currently broken due to two recent merges not playing nicely together. Specifically, #113 moves CI to stable, and #118 adds an arithmetic lint. The lint requires an exception in its configuration to avoid false positives, but this doesn't work on stable. The two changes were never tested in CI together, so this wasn't caught prior to merging.

One fix is to remove the lint. The other is to move the linting CI to nightly, noting (as in #112) that moving beyond nightly-2024-02-04 will break due to an incompatibility with the curve library.

@AaronFeickert
Copy link
Contributor Author

This only appears to arise in the work-in-progress #94, which updates the curve library. Closing since it's not directly relevant to the current codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant