ci: move to stable toolchain #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
We could hide the QuickCheck fuzzing behind a feature flag and only do CI for that using nightly (similar to what was requested in monero-rs). I find it quite handy to have that kind of testing as part of CI.
|
I think that requires nightly, since without a nightly-only compiler flag, all development dependencies are pulled in. This breaks on targets that don't support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all CI to the stable toolchain, with the single exception of formatting (which requires nightly). It does this by cleaning up the
randfeature to userand_core::OsRng, which lets theno_stdbuild run properly on stable.Unfortunately, there is no good way to do this while keeping
quickcheckaround. This was only used for very limited fuzz testing; while having any fuzz testing be part of CI is nice, its practical benefit is likely minimal. Further, its functionality is available through the non-CI fuzzer.