Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document optimizations #43

Closed
AaronFeickert opened this issue Jul 19, 2023 · 1 comment · Fixed by #46
Closed

Document optimizations #43

AaronFeickert opened this issue Jul 19, 2023 · 1 comment · Fixed by #46

Comments

@AaronFeickert
Copy link
Contributor

The codebase includes optimizations from the Bulletproofs+ preprint that may not be obvious to a reviewer. These should be better documented.

One optimization is batch verification, which is described only informally in the preprint. This is described in more detail in RFC-0181, which should be linked.

Another optimization is to the vector d, whose entries and sum are computed efficiently. This should also be documented.
This was referenced Jul 20, 2023
Merged
Merged
@AaronFeickert
Copy link
Contributor Author

The sum optimization is now added via an RFC PR.

@CjS77 CjS77 closed this as completed in #46 Jul 21, 2023
CjS77 pushed a commit that referenced this issue Jul 21, 2023
@AaronFeickert
docs: add link to RFC-0181 (#46)
078f2b1 
Several of the optimizations used in this implementation are documented
in [Tari RFC-0181](https://rfc.tari.com/RFC-0181_BulletproofsPlus.html).
This PR adds a documentation link to this RFC to make it easier to find.

Closes [issue
43](#43).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add link to RFC-0181 AaronFeickert/bulletproofs-plus
1 participant
@AaronFeickert