Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin nightly version on source cov workflow #120

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

CjS77
Copy link
Contributor

@CjS77 CjS77 commented Mar 5, 2024

A bandaid over the issue of source coverage failing due to Dalek being a naughty library again.

Clearly a temporary fix, since this will break again some thim in the future.

@AaronFeickert
Copy link
Contributor

AaronFeickert commented Mar 5, 2024

Can stable be used here, similarly to the coverage script in tari-crypto?

A bandaid over the issue of source coverage failing due to Dalek being a
naughty library again.

Clearly a temporary fix, since this will break again some thim in the
future.
@CjS77 CjS77 merged commit 1aa7694 into main Mar 5, 2024
8 checks passed
@CjS77 CjS77 deleted the pin-nightly-on-cov branch March 5, 2024 15:33
Copy link
Contributor

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like this can be tested without merging, but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants