docs: update documentation and remove old benchmarks #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjS77
approved these changes
Jul 5, 2023
CjS77
pushed a commit
to tari-project/rfcs
that referenced
this pull request
Jul 28, 2023
Description --- Adds details of a Bulletproofs+ optimization to RFC-0181. Removes old benchmark data. Motivation and Context --- The [Bulletproofs+ implementation](https://github.com/tari-project/bulletproofs-plus) contains a particular optimization used when [computing](https://github.com/tari-project/bulletproofs-plus/blob/d495fb24f9c7c34e0bfb0a38598b67e216fc56bf/src/range_proof.rs#L616-L625) a vector sum. This optimization is not particularly obvious, as it uses some fun arithmetic and a fact about [geometric series partial sums](https://mathworld.wolfram.com/GeometricSeries.html). This PR adds details about the math behind the optimization to [RFC-0181](https://rfc.tari.com/RFC-0181_BulletproofsPlus.html). It also removes outdated benchmark data, similarly to earlier [removal](tari-project/bulletproofs-plus#37) in the Bulletproofs+ repository. How Has This Been Tested? --- The changes build and render properly. The underlying mathematics should be manually checked for correctness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks used in the documentation are out of date. This PR updates the documentation to remove them and provide a better overview of the features of the implementation.
Closes #36.