Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OMS, IMS and OMP to shutdown cleanly #374

Closed
sdbondi opened this issue Jun 12, 2019 · 2 comments
Closed

Allow OMS, IMS and OMP to shutdown cleanly #374

sdbondi opened this issue Jun 12, 2019 · 2 comments
Assignees
Labels
C-bug Category - fixes a bug, typically associated with an issue. C-enhancement Category - New feature or request C-tech_debt tidies up technical debt
Milestone

Comments

@sdbondi
Copy link
Member

sdbondi commented Jun 12, 2019

The CommsBuilder must have a way to block program execution for the lifetime of the comms layer and be able to cleanly shutdown all comms services. (some background: rust-lang/rust#48820) This is currently not possible as there is no way for IMS, OMS and OMP to cleanly exit their threads.

@sdbondi sdbondi added C-bug Category - fixes a bug, typically associated with an issue. C-tech_debt tidies up technical debt C-enhancement Category - New feature or request and removed C-bug Category - fixes a bug, typically associated with an issue. labels Jun 12, 2019
@sdbondi sdbondi added this to the Testnet 1 milestone Jun 12, 2019
@CjS77
Copy link
Collaborator

CjS77 commented Jun 12, 2019 via email

@sdbondi
Copy link
Member Author

sdbondi commented Jun 13, 2019

I do in peer connection (w/ connection manager) and control service, with a thread shutdown signal - but the IMS, OMP and OMS don't

@neonknight64 neonknight64 self-assigned this Jun 19, 2019
neonknight64 pushed a commit that referenced this issue Jun 20, 2019
…wn_cleanly

# Conflicts:
#	comms/src/inbound_message_service/msg_processing_worker.rs
@CjS77 CjS77 closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - fixes a bug, typically associated with an issue. C-enhancement Category - New feature or request C-tech_debt tidies up technical debt
Projects
None yet
Development

No branches or pull requests

3 participants