Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump multiaddr and serde deps, upgrade rust to a newer nightly #2533

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Jan 14, 2021

Description

Upgrades parity-multiaddr and serde deps, which also entailed using a newer rust nightly, fixing some compilation issues, and updating the dockerfile and CI definitions. A typical yak shave.

Motivation and Context

The docker build had a failing issue with the newer version of serde. version 1.0.119 has changed the visibility of its "export" module to private, requiring an update of the multiaddr crate and some code imports.

libp2p/rust-libp2p#1912

How Has This Been Tested?

  • builds are working locally, in docker, and CI
  • cargo test -p tari_comms

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@delta1 delta1 requested a review from sdbondi January 14, 2021 12:45
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stringhandler stringhandler merged commit 87a4344 into tari-project:development Jan 15, 2021
@delta1 delta1 deleted the quay3 branch March 19, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants