Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validator registration timelock #5978

Open
wants to merge 5 commits into
base: feature-dan2
Choose a base branch
from

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Nov 22, 2023

Description

Add VN registration timelock. It has to be set to at least for the validity period (base on current consensus).
Fix the money lock value, add a test value of 1T to it.

Motivation and Context

Fixes tari-project/tari-dan#831

How Has This Been Tested?

I did register a VN, and the I checked if it's timelocked in the wallet.

What process can a PR reviewer use to test or verify this change?

Register VN and see the timelock in the wallet.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link

github-actions bot commented Nov 22, 2023

Test Results (CI)

    3 files    107 suites   31m 37s ⏱️
1 295 tests 1 294 ✅ 0 💤 1 ❌
3 214 runs  3 213 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 2a66889.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 22, 2023
Copy link

github-actions bot commented Nov 22, 2023

Test Results (Integration tests)

 2 files  11 suites   12m 10s ⏱️
32 tests 31 ✅ 0 💤 1 ❌
34 runs  31 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 2a66889.

♻️ This comment has been updated with latest results.

SWvheerden
SWvheerden previously approved these changes Nov 23, 2023
hansieodendaal
hansieodendaal previously approved these changes Apr 16, 2024
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Just one comment please.

hansieodendaal
hansieodendaal previously approved these changes Apr 18, 2024
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants