Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boilerplate for base node FSM #834

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Add boilerplate for base node FSM #834

merged 1 commit into from
Oct 11, 2019

Conversation

CjS77
Copy link
Collaborator

@CjS77 CjS77 commented Oct 10, 2019 •
edited
Loading 

Adds stubs for the missing state structs in the base node FSM.
Provide comments for allowed state conversions.

What's quite nice about doing it this way is that the _compiler_ will tell you
if you try and enact an illegal state change, e.g. from Startup -> Listening;
becuase the From trait isn't written for that change.

neonknight64
neonknight64 previously approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@neonknight64 neonknight64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CjS77
Add boilerplate for base node FSM
7ee6990 
Adds stubs for the missing state structs in the base node FSM.
Provide comments for allowed state conversions.

What's quite nice about doing it this way is that the _compiler_ will tell you
if you try and enact an illegal state change, e.g. from Startup -> Listening;
becuase the From trait isn't written for that change.
@CjS77 CjS77 force-pushed the missing_node_states branch from 32dc8c7 to 7ee6990 Compare October 11, 2019 06:30
neonknight64
neonknight64 approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@neonknight64 neonknight64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CjS77 added a commit that referenced this pull request Oct 11, 2019
@CjS77
Add boilerplate for base node FSM (#834)
254b2d0 
Merge pull request #834

Adds stubs for the missing state structs in the base node FSM.
Provide comments for allowed state conversions.

What's quite nice about doing it this way is that the _compiler_ will tell you
if you try and enact an illegal state change, e.g. from Startup -> Listening;
becuase the From trait isn't written for that change.
@CjS77 CjS77 merged commit 7ee6990 into development Oct 11, 2019
@CjS77 CjS77 deleted the missing_node_states branch October 11, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonknight64 neonknight64 neonknight64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CjS77 @neonknight64