Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

tari-project / tari Public

Notifications You must be signed in to change notification settings
Fork 216
Star 350

Code
Issues 144
Pull requests 10
Discussions
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply LWMA algo with diff adjustiment trait #971

Merged

CjS77 merged 1 commit into development from SW_LWMA

Nov 6, 2019

Merged

Apply LWMA algo with diff adjustiment trait #971

CjS77 merged 1 commit into development from SW_LWMA

Nov 6, 2019

Conversation 31 Commits 1 Checks 0 Files changed

Conversation

Copy link

Collaborator

SWvheerden commented Nov 4, 2019

Description

This PR adds in a difficulty adjustment algorithm.

Motivation and Context

We need to adjust the difficulty per block. This PR adds the LWMA algorithm as per zawy12/difficulty-algorithms#3
This should be proficient for early testnet versions.

How Has This Been Tested?

Added unit test testing for changes in the algorithm.

Types of changes

Bug fix (non-breaking change which fixes an issue)S
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
New Tests
Documentation

Checklist:

I'm merging against the development branch
I ran cargo-fmt --all before pushing
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.

Sorry, something went wrong.

All reactions

SWvheerden force-pushed the SW_LWMA branch from 70cb6d7 to 590e44d Compare

November 4, 2019 13:25

SWvheerden added this to the TestNet Release milestone

SWvheerden force-pushed the SW_LWMA branch from 590e44d to c5299e0 Compare

November 5, 2019 04:51

neonknight64 reviewed

View reviewed changes

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

CjS77 reviewed

View reviewed changes

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

neonknight64 reviewed

View reviewed changes

base_layer/core/src/proof_of_work/difficulty.rs Outdated Show resolved Hide resolved

neonknight64 reviewed

View reviewed changes

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

neonknight64 reviewed

View reviewed changes

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

neonknight64 reviewed

View reviewed changes

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

neonknight64 reviewed

View reviewed changes

base_layer/core/src/proof_of_work/lwma.rs Outdated Show resolved Hide resolved

neonknight64 reviewed

View reviewed changes

base_layer/core/src/proof_of_work/mod.rs Outdated Show resolved Hide resolved

SWvheerden force-pushed the SW_LWMA branch from 9902e0a to becd7be Compare

November 5, 2019 12:25

CjS77 reviewed

View reviewed changes

Copy link

Collaborator

CjS77 left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; a few things for readability and then we can merge

Sorry, something went wrong.

All reactions

base_layer/core/src/proof_of_work/lwma_diff.rs Outdated Show resolved Hide resolved

base_layer/core/src/proof_of_work/lwma_diff.rs Outdated Show resolved Hide resolved

base_layer/core/src/proof_of_work/lwma_diff.rs Outdated Show resolved Hide resolved

base_layer/core/src/proof_of_work/lwma_diff.rs Outdated Show resolved Hide resolved

SWvheerden force-pushed the SW_LWMA branch from becd7be to 4772bfa Compare

November 5, 2019 13:48

CjS77 force-pushed the SW_LWMA branch from 4772bfa to 27f0f61 Compare

November 6, 2019 11:40


Add LWMA difficulty adjustment algorithm

9725a1b

This PR adds in a difficulty adjustment algorithm.

Motivation and Context

We need to adjust the difficulty per block. This PR adds the LWMA
algorithm as per zawy12/difficulty-algorithms#3

CjS77 force-pushed the SW_LWMA branch from 27f0f61 to 9725a1b Compare

November 6, 2019 11:57

CjS77 approved these changes

View reviewed changes

Copy link

Collaborator

CjS77 left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

All reactions

CjS77 added a commit that referenced this pull request


Add LWMA difficulty adjustment algorithm (#971)

62b4680

Merge pull request #971

We need to adjust the difficulty per block. This PR adds the LWMA
algorithm as per zawy12/difficulty-algorithms#3

CjS77 merged commit 9725a1b into development

CjS77 deleted the SW_LWMA branch

November 6, 2019 12:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

neonknight64 neonknight64 left review comments

CjS77 CjS77 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

TN

Development

Successfully merging this pull request may close these issues.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.