-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): windows debug symbols upload and yq warnings removed #1580
Conversation
📝 WalkthroughWalkthroughThe release workflow configuration has been updated. The Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI Workflow
participant YQ as yq Commands
participant CONF as tauri.conf.json
participant ART as Artifact Locator
participant UDS as Debug Symbols Uploader
CI->>YQ: Execute yq eval commands with --output-format=json
YQ->>CONF: Update productName, mainBinaryName, title, identifier, endpoints
CI->>ART: Run step "Locate artifacts path"
ART-->>CI: Provide artifact path
CI->>UDS: Upload tari_universe.pdb debug symbols
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/release.yml (2)
238-246
: Step renaming for clarity improves workflow readability.
The step formerly known as "Debug Step - artifactPaths" is now renamed to "Locate artifacts path." This change improves clarity with no functional impact.
254-259
: New Windows debug symbols upload step is correctly configured.
The added step for uploading Windows debug symbols (tari_universe.pdb
) appears correct. Verify that the file at${{ github.workspace }}/src-tauri/target/release/tari_universe.pdb
is reliably generated during the Windows build. Optionally, consider adding a pre-upload existence check to handle cases where the file might not be present.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml
(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: tauri-build
- GitHub Check: machete
- GitHub Check: Check i18n
- GitHub Check: cargo checks (fmt, clippy, check)
🔇 Additional comments (2)
.github/workflows/release.yml (2)
92-97
: Ensure yq commands use JSON output to avoid warnings and maintain consistency.
The updated yq eval commands now include the--output-format=json
flag, which should eliminate the warnings previously generated. Please verify that your version of yq supports this flag and that the JSON-formatted output is correctly handled downstream.
118-123
: Consistent JSON formatting for RELEASE build yq invocations.
These modifications mirror the changes in the BETA build block by ensuring all tauri.conf.json updates use the--output-format=json
flag. This consistency helps avoid warnings and potential parsing issues.
Description
Windows debug symbols upload as artifact
yq warnings removed
Summary by CodeRabbit
New Features
Chores