Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): update visualisation files | fix build #45

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

shanimal08
Copy link
Collaborator

@shanimal08 shanimal08 commented Aug 12, 2024

Description

  • moved visualisation assets to public dir - this was the main reason the builds were borked !
  • replaced old visualisation files with new build (everything in /public/assets)
    • also removed unnecessary files from their build
  • updated functions in visuals.js to use the other status value, so we can stop the animation, and continue where it stopped
  • updated useMining - added started ref to know which visualiser function to use
  • updated eslint config to include globals (for document undefined errors in visuals)

Motivation and Context

  • lusion provided an updated build
  • last implementation of animation didn't stop/start properly in sync with start/stop mining
  • build did not include visualisation

How Has This Been Tested?

  • locally from dev server
  • locally after building
Screen.Recording.2024-08-12.at.11.mp4

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@shanimal08 shanimal08 changed the title wip: update visualization | eslint config fix(UI): update visualisation files | fix build Aug 12, 2024
@shanimal08 shanimal08 marked this pull request as ready for review August 12, 2024 16:35
@stringhandler stringhandler merged commit 207a970 into tari-project:main Aug 13, 2024
5 of 8 checks passed
@shanimal08 shanimal08 deleted the shan/vis branch August 13, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants