Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune-release should remove the version field in opam files #189

Closed
samoht opened this issue Nov 22, 2019 · 2 comments · Fixed by #200
Closed

dune-release should remove the version field in opam files #189

samoht opened this issue Nov 22, 2019 · 2 comments · Fixed by #200
Assignees
@gpetiot
Labels
bug Something isn't working
Milestone
1.4.0

Comments

@samoht
Copy link
Contributor

samoht commented Nov 22, 2019 •
edited
Loading

I'm using 79432f3 and the irmin release lead to: ocaml/opam-repository#15363

That would be nice to remove the existing version fields on opam files before doing a release.
@samoht samoht mentioned this issue Nov 22, 2019
Merged
@NathanReb
Copy link
Contributor

That might be a recently introduced bug. I had to fix some issues with the parts that does remove existing version fields to fix #163. I'll take a look!

@NathanReb NathanReb added this to the 1.4.0 milestone Nov 22, 2019
@gpetiot gpetiot mentioned this issue Nov 28, 2019
Merged
@gpetiot gpetiot self-assigned this Nov 28, 2019
@kit-ty-kate
Copy link
Contributor

The version field in ocaml/opam-repository#15805 was also wrong. Can this be fixed?

@gpetiot gpetiot added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpetiot gpetiot

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Do not write 'version' and 'name' fields in opam file
4 participants
@samoht @gpetiot @kit-ty-kate @NathanReb