Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune-release distrib odd lint error #163

Closed
Chris00 opened this issue Sep 9, 2019 · 8 comments · Fixed by #168
Closed

dune-release distrib odd lint error #163

Chris00 opened this issue Sep 9, 2019 · 8 comments · Fixed by #168
Labels
bug Something isn't working

Comments

@Chris00
Copy link

Chris00 commented Sep 9, 2019

On the package csv-lwt, I have:

$ opam lint
/home/trch/software/OCaml/csv/csv.opam: Passed.
/home/trch/software/OCaml/csv/csv-lwt.opam: Passed.

but

$ dune-release distrib
...
[FAIL] lint opam file csv-lwt.opam:
       opam lint -s messages:
       /home/trch/software/OCaml/csv/_build/csv-2.3/csv-lwt.opam: Errors.
                    error  2: File format error at line 31, column 63: unterminated string

That part is identical to csv.opam. I have not investigated further but this is odd to me.

@NathanReb
Copy link
Contributor

Thanks for reporting this!

I had a quick look and it seems that it is indeed a bug in dune-release. I'll investigate!

@NathanReb
Copy link
Contributor

It seems that while building the distribution archive, the csv-lwt.opam file gets truncated somehow.

@Chris00
Copy link
Author

Chris00 commented Sep 9, 2019

I'll investigate!

Thanks.

@Chris00
Copy link
Author

Chris00 commented Sep 12, 2019

With --skip-lint the archive gets built and indeed the description field is truncated:

description: """
This is a pure OCaml library to read and write CSV files, including
all extensions used by Excel — e.g. quotes, newlines, 8 bit characters
in fields, \"0 etc. A special representation of rows of CSV files with
a header is provided. The library comes with a handy command line tool
called csvtool for handling CSV files from shell scripts.  This

@Chris00
Copy link
Author

Chris00 commented Sep 12, 2019

@NathanReb Can you reproduce the bug on your side?

@NathanReb
Copy link
Contributor

Yes I can reproduce! I haven't had time to investigate further unfortunately :/

Chris00 added a commit to Chris00/ocaml-csv that referenced this issue Sep 12, 2019
@Chris00
Copy link
Author

Chris00 commented Sep 12, 2019

This is fine: strangely enough, just modifying the line a little works around the bug.

@NathanReb NathanReb added the bug Something isn't working label Sep 12, 2019
@NathanReb
Copy link
Contributor

I'm glad to hear that! It's still a nasty bug though and I will definitely work on fixing that before the next patch release, which is hopefully coming soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants