Fix a bug in opam file transformation for distrib #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
force-pushed
the
fix-weird-opam-truncation
branch
from
ebcf268 to
ea2a0fe
Compare
|
Looks good, thanks! |
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Sep 30, 2019
CHANGES: ### Fixed - Fix a bug where `opam submit` would fail if the opam files had no description (tarides/dune-release#165, @NathanReb) - Fix a bug where opam files could be inproperly tempered with while building the distribution tarball (tarides/dune-release#168, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
The code that adds the version to the opam file before building the distrib tarball was a bit lax and in some cases (like in #163) it would filter out lines that weren't actually the version field line.
This PR adds a few tests and strengthen that part of the code a bit.
The proper fix would probably be to use opam's libary for that but I think a quick fix will do for now. We won't need to do this anymore when integrating into dune!