Make description optional for opam submit #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tarides#164 This makes the description field optional when submitting a PR to opam-repository. Given that opam considers it okay as long as there's a synopsis I think it make sense to allow a missing description field. We might even consider make that just a warning in the lint phase as well but that's a separate matter I'd say. The important is that it doesn't prevent one from releasing!
|
LGTM |
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Sep 30, 2019
CHANGES: ### Fixed - Fix a bug where `opam submit` would fail if the opam files had no description (tarides/dune-release#165, @NathanReb) - Fix a bug where opam files could be inproperly tempered with while building the distribution tarball (tarides/dune-release#168, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164
This makes the description field optional when submitting a PR to opam-repository.
Given that opam considers it okay as long as there's a synopsis I think it make sense to allow a missing description field. We might even consider make that just a warning in the lint phase as well but that's a separate matter I'd say. The important is that it doesn't prevent one from releasing!