Clean up lock file and internal representations #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
force-pushed
the
clean-lock-file
branch
from
2416429 to
d2daf21
Compare
NathanReb
changed the title
NathanReb
force-pushed
the
clean-lock-file
branch
from
d2daf21 to
80cf643
Compare
|
The CI failure is on 4.12 and seems related to a known bug in dune so I'm ignoring it for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks a little bit how we represent the duniverse and the lockfile internally.
It also makes the lockfile closer to a regular opam file. When rebuilding the duniverse representation from the lockfile it relies on regular opam fields such as
pin-dependsalong with some extra fields that are required to keep the implementation simple while not relying on opam to collect pieces of data (especially since those could have changed since the lock).