Improve detection of packages building with dune #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
force-pushed
the
improve-build-with-dune
branch
from
4d2bf7b
to
1b7a95f
Compare
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Jun 29, 2021
CHANGES: ### Added - Add `--ocaml-version` argument to `lock`: it allows to determine the ocaml version in the lockfile that's being generated (tarides/opam-monorepo#161, @pitag-ha) ### Changed - Exclude packages depending on `jbuilder` from the lock step. Since dune 2.0, `jbuild` files are not supported. A new `--allow-jbuilder` option have been added to enable the old behavior. - Recognize packages with an optional dependency on dune as building with dune. This allows opam-monorepo to rightfully recognize `opam-file-format` latest versions as building with dune. (tarides/opam-monorepo#176, @NathanReb) - Only print the full list of selected root packages once and only in verbose mode, simply printing the number in the default logs. (tarides/opam-monorepo#173, @NathanReb) - Improve the solving process so it only accepts base-compilers unless one explicitly requires a compiler variant, either directly or using `ocaml-option-*` packages. (tarides/opam-monorepo#178, @NathanReb) ### Deprecated ### Fixed - Fix the default branch mechanism when the opam remote starts with `git+https` (tarides/opam-monorepo#166, @TheLortex) - Fix a log that was still refering to the old tool name `duniverse` (tarides/opam-monorepo#158, @rizo) - Improve how the default branch for a git repository is queried, fixing a bug where opam-monorepo wouldn't work outside of of git repo and a bug where it wouldn't work on non-english systems. (tarides/opam-monorepo#157, fixes tarides/opam-monorepo#114, @TheLortex) ### Removed ### Security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages such as
opam-file-formatare compatible with dune but don't use it as their primary build mechanism. They mark dune as an optional dependency which made opam-monorepo think they weren't building with dune when they actually could be built with it and therefore could be vendored in a duniverse.This PR fixes that.