-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore pinned packages when building dev-repo conflicts #398
Ignore pinned packages when building dev-repo conflicts #398
Conversation
b3fdcbd
to
2b75025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you describe the change better? The code doesn't make me go "aha, so this is because of pinned repos", would be nice to have a better description of the change and why it fixes the problem.
Co-authored-by: @reynir <reynir@reynir.dk>
e06a063
to
a0c00df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes would make it better but the overall form seems ok - let's give it a chance!
Co-authored-by: Marek Kubica <marek@xivilization.net>
Thanks, I've pushed fixes to address your review. Not totally sure what tests you wanted me to add, so I've just added a very simple one. |
Looks good, thanks! Any test is better than no test and a starting point for more tests :) |
This allows to pin a single package for multi-repository. In that case Opam-monorepo will always choose the pinned repository, so adding conflicts is just confusing the solver.