-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fuchsia Trace Format output to olly #6
Conversation
FTF is a binary format viewable in Perfetto. FTF is supported by the opam tracing package. This commit is a simple change to add FTF output to olly, following the [trace] code that already outputs Chrome Tracing Format traces.
Thanks. It would be useful to check whether the same traces are produced for If you happen to run a long-running program, could you report the size of the |
Some more data after running binarytrees5_multicore.ml from sandmark. The test was run with 3 domains and varying arguments for
I think we expected better the binary format to have a better ratio than this as n increases. At the moment, the long binary traces seem to be only about 5.8 times smaller than the json equivalent. [Update: trying n at 24 and 25, the ratio is still about 5.8; json file size is 232MB for n=25] |
If I am reading the PR right, this introduces a new command A better way to do this would be to introduce an option under the existing $ olly trace --format json prog.trace prog.exe # emits the trace in json format
$ olly trace --format fuschia prog.trace prog.exe # emits the trace in fuschia trace format
$ olly trace prog.trace prof.exe # emits the trace in fuschia trace format |
I've implemented your request - hopefully the command line interface is now a bit more sensible. (I am a cmdliner novice, so let me know if this is still not right.) |
Thanks. I’ll get to this tomorrow. |
b9aea54
to
8dd70b2
Compare
Trace format can be either "json" (compatible with Chrome tracing) or "fuchsia" (Fuchsia Trace Format, a binary format that can be used with Perfetto).
8dd70b2
to
3201e40
Compare
LGTM. |
CHANGES: * Fix dependencies (tarides/runtime_events_tools#14, @Sudha247) * Improve JSON output produced by olly gc-stats (tarides/runtime_events_tools#13, @punchagan) * Mention Fuchsia format in the README (tarides/runtime_events_tools#11, @Sudha247) * Gc subcommand (tarides/runtime_events_tools#10, @Sudha247) * Add Fuchsia Trace Format output to olly (tarides/runtime_events_tools#6, @tomjridge) * Added --output option to redirect olly printing (tarides/runtime_events_tools#5, @ElectreAAS) * Added json printing option (tarides/runtime_events_tools#4, @ElectreAAS)
FTF is a binary format viewable in Perfetto. FTF is supported by the opam tracing package. This commit is a simple change to add FTF output to olly, following the [trace] code that already outputs Chrome Tracing Format traces.