-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FORCE_COLOR and NO_COLOR environment variables #230
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c5dfed5
ci: add GHA workflow 'test'
eine cfe9cb7
Added FORCE_COLOR and NO_COLOR environment variables
jhol 8853980
Merge branch 'master' into force-color
tartley 9f8c1a0
ci: update setup-msys2 action
eine 3da1a87
merge 'upstream/master' into ci-gha
eine 9331754
Fixed typo
jhol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -87,14 +87,25 @@ def __init__(self, wrapped, convert=None, strip=None, autoreset=False): | |||||
# to support the ANSI codes. | ||||||
conversion_supported = on_windows and winapi_test() | ||||||
|
||||||
# if the stream is not closed, check if it's a TTY | ||||||
not_closed = not self.stream.closed | ||||||
|
||||||
# check if the FORCE_COLOR environment variable has been set and NO_COLOR has not been set. | ||||||
if 'NO_COLOR' in os.environ: | ||||||
color_allowed = False | ||||||
elif 'FORCE_COLOR' in os.environ: # overridden by NO_COLOR | ||||||
color_allowed = True | ||||||
else: | ||||||
color_allowed = not_closed and self.stream.isatty() | ||||||
|
||||||
# should we strip ANSI sequences from our output? | ||||||
if strip is None: | ||||||
strip = conversion_supported or (not self.stream.closed and not self.stream.isatty()) | ||||||
strip = conversion_supported or (not_closed and not color_allowed) | ||||||
self.strip = strip | ||||||
|
||||||
# should we should convert ANSI sequences into win32 calls? | ||||||
if convert is None: | ||||||
convert = conversion_supported and not self.stream.closed and self.stream.isatty() | ||||||
convert = conversion_supported and not_closed and color_allowed | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
self.convert = convert | ||||||
|
||||||
# dict of ansi codes to win32 functions and parameters | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.