Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ASCII decoding explicitly in setup.py #294

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

neirbowj
Copy link
Contributor

@neirbowj neirbowj commented Nov 22, 2020

Prevents future regression of #291 following 688f6cc

@neirbowj
Copy link
Contributor Author

Dealt with a style nit.

@yzgyyang
Copy link

Bump.

@wiggin15
Copy link
Collaborator

As discussed in #291, README should be ascii and not unicode. Since README is now ascii again, a new release will solve this issue, so we don't really have to change the code.
We may want to set the encoding explicitly to "ascii" to avoid this mistake in the future - I will accept a PR for that.
(by the way, this is discussed in PEP 597)

@neirbowj neirbowj changed the title Default to UTF-8 decoding in setup.py Use ASCII decoding explicitly in setup.py Dec 31, 2020
setup.py Show resolved Hide resolved
@wiggin15 wiggin15 merged commit 7a85efb into tartley:master Feb 11, 2021
@wiggin15
Copy link
Collaborator

Thank you!

@neirbowj neirbowj deleted the explicit_encoding branch February 11, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants