Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Fix error handling in continuation token #7290

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

lotas
Copy link
Contributor

@lotas lotas commented Sep 30, 2024

hashids.decode throw an error when input contains unexpected characters.
This wraps the handling and responds 400 to the client instead of 500

@lotas lotas requested a review from a team as a code owner September 30, 2024 09:16
@lotas lotas requested review from petemoore and matt-boris and removed request for a team September 30, 2024 09:16
Copy link
Contributor

@matt-boris matt-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty

@lotas lotas merged commit 1f50152 into main Sep 30, 2024
73 checks passed
@lotas lotas deleted the fix/auth-pagination branch September 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants