Allow expiration to be overridden in fetch and docker-image kinds. Allow setting the default expiry on "try" tasks

[gabrielBusta]

fixes #392
fixes #393
fixes #350
fixes #351

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29ebb22) 60.06% compared to head (4131a6c) 60.06%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   60.06%   60.06%           
=======================================
  Files          69       69           
  Lines        6360     6361    +1     
  Branches     1284     1284           
=======================================
+ Hits         3820     3821    +1     
  Misses       2254     2254           
  Partials      286      286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ahal]

I think I'd prefer a name like default-task-expiry, but I see we already have task-deadline-after, so this is fine as it's better to be consistent.

[ahal]

Also bonus points for adding some tests to test_transforms_fetch.py and test_transforms_docker_image.py to fix the coverage :)

[gabrielBusta]

Thanks! I improved the patch.

I am gonna delete so much code from the translations repo when this lands :)

[gabrielBusta]

I think I'd prefer a name like default-task-expiry, but I see we already have task-deadline-after, so this is fine as it's better to be consistent.

Yeah, I was going for consistency there.

[ahal]

I think saying "non level 3" is technically incorrect because is_try() only catches pull requests and projects that contain the string "try". Saying "level 1 tasks" would be more accurate.

That said, it's kind of a shame that this only impacts level 1 tasks. What if we added an optionally_keyed_by("level", str) (like how task-deadline-after is optionally keyed by project above).

This way the graph config could look like:

task-expires-after:
    by-level:
        1: 90 days
        3: 1 year

Also, you could just set a single default for all levels:

task-expires-after: 1 year

Feel free to leave as a follow-up, but would be nice to have an issue on file at least.

[gabrielBusta]

I looked into it a bit and filed #410