-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
So many errors in typescript code #112
Comments
This seems to be specific to your editor setup, there are no errors as demonstrated by the builds in travis. |
No, it's not all ide setup errors. For example: My variant ( valid typings )
Your variant ( invalid typings )
|
You are probably compiling with different settings. As you see the library compiles just fine in Travis, otherwise the tests would not pass. |
You assign variable with type RateLimiterOptions the value null. In my opinion, this is a mistake |
Pls, use |
In your typings, limiter - is always exists and can't be null. But it false |
you are welcome to submit a PR and then we can discuss if it can be merged. |
After clone, i see many errors and can't build project.
I think, you should use eslnit + tsc with right configs.
tsconfig.json
.eslintrc.js
The text was updated successfully, but these errors were encountered: