Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: SandboxedJob interface missing the queueName prop #2439

Closed
1 task done
Matthew-John-Emerson opened this issue Feb 21, 2024 · 0 comments · Fixed by #2446
Closed
1 task done

[Bug]: SandboxedJob interface missing the queueName prop #2439

Matthew-John-Emerson opened this issue Feb 21, 2024 · 0 comments · Fixed by #2446
Labels
bug Something isn't working

Comments

@Matthew-John-Emerson
Copy link

Version

5.3.0

Platform

NodeJS

What happened?

The SandboxedJob interface is missing the queueName prop. However, it is already a part of the actual sandboxedJob object. This is even enforced by typescript as JobJsonSandbox has both queueName and prefix as additional data. This is happening because SandboxedJob is defined in terms of JobJson instead of JobJsonSandbox.

How to reproduce.

import { SandboxedJob } from 'bullmq'
export default async (sandboxedJob: SandboxedJob) => {
    await job.log('Working on job from', sandboxedJob.queueName)
}

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Matthew-John-Emerson Matthew-John-Emerson added the bug Something isn't working label Feb 21, 2024
@Matthew-John-Emerson Matthew-John-Emerson changed the title [Bug]: [Bug]: SandboxedJob interface missing the queueName prop Feb 21, 2024
@roggervalf roggervalf mentioned this issue Feb 23, 2024
Merged
roggervalf added a commit that referenced this issue Feb 24, 2024
@roggervalf
fix(sandbox): extend SandboxedJob from JobJsonSandbox (#2446) fixes #…
7606e36 
…2439
github-actions bot pushed a commit that referenced this issue Feb 24, 2024
@semantic-release-bot
chore(release): 5.3.2 [skip ci]
927d2a5 
## [5.3.2](v5.3.1...v5.3.2) (2024-02-24)

### Bug Fixes

* **sandbox:** extend SandboxedJob from JobJsonSandbox ([#2446](#2446)) fixes [#2439](#2439) ([7606e36](7606e36))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sandbox): extend SandboxedJob from JobJsonSandbox taskforcesh/bullmq
1 participant
@Matthew-John-Emerson