Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Stalled jobs dont fail their parents #2464

Closed
1 task done
otanriverdi opened this issue Mar 6, 2024 · 4 comments · Fixed by #2526
Closed
1 task done

[Bug]: Stalled jobs dont fail their parents #2464

otanriverdi opened this issue Mar 6, 2024 · 4 comments · Fixed by #2526
Labels
bug Something isn't working

Comments

@otanriverdi
Copy link

Version

5.1.1

Platform

NodeJS

What happened?

I have a job with a parent and the job is configured with failParentOnFailure set to true. This works as expected if the job errors in anyway. But if the jobs stalls more then the allowable limits and ends up in the job stalled more then allowable limit state, the parent does not get failed and the flow esentially gets stuck.

How to reproduce.

  • Have a job with a dependency
  • Set the stalledCount to 1
  • Manually kill the dependency job twice to simulate stall

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@otanriverdi otanriverdi added the bug Something isn't working label Mar 6, 2024
@roggervalf
Copy link
Collaborator

hey, I'll take a look this week

@juanjalil
Copy link

Having the same issue when using ignoreDependencyOnFailure. Any resolution on this one? Thanks!

@roggervalf roggervalf mentioned this issue Apr 16, 2024
Merged
roggervalf added a commit that referenced this issue Apr 18, 2024
@roggervalf
fix(stalled): consider failParentOnFailure when moving child into fai…
5e31eb0 
…led (#2526) fixes #2464 (python)
github-actions bot pushed a commit that referenced this issue Apr 18, 2024
@semantic-release-bot
chore(release): 5.7.2 [skip ci]
c97a43b 
## [5.7.2](v5.7.1...v5.7.2) (2024-04-18)

### Bug Fixes

* **stalled:** consider failParentOnFailure when moving child into failed ([#2526](#2526)) fixes [#2464](#2464) (python) ([5e31eb0](5e31eb0))

### Features

* **queue:** add getJobLogs method [python] ([#2523](#2523)) ref [#2472](#2472) ([a24a16e](a24a16e))
* **worker:** use 0.002 as minimum timeout for redis version lower than 7.0.8 [python] ([#2521](#2521)) ([f3862dd](f3862dd))
@juanjalil
Copy link

@roggervalf tried the fix, but it looks not to be working with ignoreDependencyOnFailure. Child jobs are failed but parent doesn't.

@roggervalf
Copy link
Collaborator

hi @juanjalil would you pls open a new issue regarding ignoreDependencyOnFailure. I can work on that in a separate pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stalled): consider failParentOnFailure when moving child into failed taskforcesh/bullmq
3 participants
@roggervalf @otanriverdi @juanjalil