-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Stacktrace with limit removes the last error stack. #2487
Labels
bug
Something isn't working
Comments
nocodehummel
added a commit
to nocodehummel/bullmq
that referenced
this issue
Mar 23, 2024
yeah, I see, this actually a real bug as we are pushing the new stacks and then slicing them away if the length is larger stackTraceLimit. |
nocodehummel
added a commit
to nocodehummel/bullmq
that referenced
this issue
Mar 25, 2024
manast
pushed a commit
that referenced
this issue
Mar 26, 2024
manast
pushed a commit
that referenced
this issue
Mar 26, 2024
closing as there is a merged fix in v5.4.6 |
hey, the solution does not allow stackTraceLimit to be set to 0, is this the desired behaviour? |
@xNest how do you mean does not allow? |
If you pass 0 with the intention of not saving a stack trace, the limit will be ignored.
|
roggervalf
added a commit
that referenced
this issue
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
5.4.5
Platform
NodeJS
What happened?
Our jobs have
stackTraceLimit
set, and we noticed that the error stack is not updated.How to reproduce.
The problem is caused by an incorrect use of slice inside the Job class.
Simple reproduction example to demonstrate the issue.
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: