Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: v5.10.0 introducing "ReplyError: CROSSSLOT Keys in request don't hash to the same slot" #2660

Closed
1 task done
arsonik opened this issue Jul 17, 2024 · 4 comments · Fixed by #2662
Closed
1 task done
Labels
bug Something isn't working

Comments

@arsonik
Copy link
Contributor

arsonik commented Jul 17, 2024

Version

3.10.0

Platform

NodeJS

What happened?

A bug happened after upgrading to v5.10.0 I get a "ReplyError: CROSSSLOT Keys in request don't hash to the same slot"
When using BullMQ against a redis cluster server configured with a '{my_prefix}' prefix !

How to reproduce.

No response

Relevant log output

ReplyError: CROSSSLOT Keys in request don't hash to the same slot
    at parseError (xxx/node_modules/.pnpm/redis-parser@3.0.0/node_modules/redis-parser/lib/parser.js:179:12)
    at parseType (xxx/node_modules/.pnpm/redis-parser@3.0.0/node_modules/redis-parser/lib/parser.js:302:14)

Code of Conduct

  • I agree to follow this project's Code of Conduct
@arsonik arsonik added the bug Something isn't working label Jul 17, 2024
@manast
Copy link
Contributor

manast commented Jul 17, 2024

Can you double-check check you are using the proper prefix? from which version where you upgrading?

@manast
Copy link
Contributor

manast commented Jul 17, 2024

As a sidetone, all our test suite runs against using a custom prefix so that we can run DragonflyDBs tests, so it is unlikely we have introduced a regression in this regard.

@arsonik
Copy link
Contributor Author

arsonik commented Jul 17, 2024

As a sidetone, all our test suite runs against using a custom prefix so that we can run DragonflyDBs tests, so it is unlikely we have introduced a regression in this regard.

are the tests running on a cluster with multiples nodes ?

and yes I've doubled checked, 5.9.0 works 5.10.0 doesn't

@arsonik
Copy link
Contributor Author

arsonik commented Jul 17, 2024

based on the GitHub actions redis's image
https://github.com/supercharge/redis-github-action
it doesn't look like it's an actual cluster with multiple node!
so all tests with {key} prefixes might be compromised ?

github-actions bot pushed a commit that referenced this issue Jul 18, 2024
## [5.10.1](v5.10.0...v5.10.1) (2024-07-18)

### Bug Fixes

* **repeatable:** consider removing legacy repeatable job ([#2658](#2658)) fixes [#2661](#2661) ([a6764ae](a6764ae))
* **repeatable:** pass custom key as an args in addRepeatableJob to prevent CROSSSLOT issue ([#2662](#2662)) fixes [#2660](#2660) ([9d8f874](9d8f874))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants