[Bug]: Setting a concurrency doesn't change the concurrency field on the worker

[nlochschmidt]

Version

v5.22.0

Platform

NodeJS

What happened?

When we set a concurrency on a worker in the constructor and then set a new concurrency using the setter worker.concurrency = 10, then worker.concurrency is still the concurrency of the worker set in the constructor is undefined.

We can use worker.opts.concurrency to get the current concurrency but this seems like a bug.

Relevant code:

bullmq/src/classes/worker.ts

Line 241 in 092019f

this.concurrency = this.opts.concurrency;

and

bullmq/src/classes/worker.ts

Lines 387 to 396 in 092019f

	set concurrency(concurrency: number) {
	if (
	typeof concurrency !== 'number' ||
	concurrency < 1 ||
	!isFinite(concurrency)
	) {
	throw new Error('concurrency must be a finite number greater than 0');
	}
	this.opts.concurrency = concurrency;
	}

How to reproduce.

const worker = new Worker('test', async job => {}, { concurrency: 100 });
worker.concurrency = 10
assert(worker.concurrency == 10)

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[nlochschmidt]

Oh, actually, it seems like the value of worker.concurrency is also not the one from the constructor but actually undefined, but TypeScript doesn't complain about this:

const maxTasks: number = worker.concurrency

[nlochschmidt]

Related microsoft/TypeScript#11596 (comment)