Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add populate_dependency_context to fix bug when using InMemoryBroker #2

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

tschiolborg
Copy link
Contributor

@tschiolborg tschiolborg commented May 11, 2023

When using InMemoryBroker the dependency context is never set.

I have added populate_dependency_context so it can be set manually, as well as adding documentation to make users aware.
The function may also be useful when setting up tests.

I also fixed some typos.

Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best request I've ever seen. Magnificent.

@s3rius s3rius merged commit b6b4b92 into taskiq-python:develop May 11, 2023
@tschiolborg tschiolborg deleted the develop branch May 11, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants